add relation macros and add relation renameable/replaceable config #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
reviewed
Sep 13, 2023
| {%- set contract_config = config.get('contract') -%} | ||
| {%- if contract_config.enforced -%} | ||
|
|
||
| create table |
There was a problem hiding this comment.
These (this line and line 36) should be create or replace instead of just create.
There was a problem hiding this comment.
I don't think redshift supports or replace
There was a problem hiding this comment.
If Redshift doesn't support create or replace for tables, then we need to remove RelationType.Table from replaceable_relations and then delete this file.
There was a problem hiding this comment.
good point! duh
tests/functional/adapter/materialized_view_tests/test_materialized_views.py
Outdated
Show resolved
Hide resolved
mikealfare
approved these changes
Sep 13, 2023
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
…bt-labs#603) * add relation macros and add relation renameable/replaceable config * formatting cleanup * PR fixes * make tables irreplaceable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist